feat(translator): support setting previous priorities retry predicate#6204
Merged
arkodg merged 2 commits intoenvoyproxy:mainfrom Jun 11, 2025
Merged
feat(translator): support setting previous priorities retry predicate#6204arkodg merged 2 commits intoenvoyproxy:mainfrom
arkodg merged 2 commits intoenvoyproxy:mainfrom
Conversation
Inode1
force-pushed
the
feat-retry-remote-locality
branch
from
3bdbbac to
c2b5bdf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6204 +/- ##
=======================================
Coverage 70.48% 70.48%
=======================================
Files 220 220
Lines 36676 36691 +15
=======================================
+ Hits 25852 25863 +11
- Misses 9292 9294 +2
- Partials 1532 1534 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Inode1
force-pushed
the
feat-retry-remote-locality
branch
from
c2b5bdf to
a7569fd
Compare
Contributor
Author
|
/retest |
cmaddalozzo
reviewed
Jun 2, 2025
Inode1
force-pushed
the
feat-retry-remote-locality
branch
3 times, most recently
from
224f66f to
6e34d40
Compare
arkodg
reviewed
Jun 2, 2025
api/v1alpha1/retry_types.go
Outdated
Contributor
There was a problem hiding this comment.
Suggested change
| // If not specified or set to 0, all requests are sent to the highest priority. | |
| // If not specified or set to 0, all requests are sent to the highest priority that is healthy. |
Contributor
|
thanks @Inode1 the PR looks good, added a minor comment |
Inode1
force-pushed
the
feat-retry-remote-locality
branch
2 times, most recently
from
d20ec44 to
c208aeb
Compare
Signed-off-by: i.makarychev <i.makarychev@tbank.ru>
Inode1
force-pushed
the
feat-retry-remote-locality
branch
from
c208aeb to
77d3a2f
Compare
Contributor
Author
Done |
Contributor
Author
|
/retest |
Signed-off-by: Arko Dasgupta <arkodg@users.noreply.github.com>
arkodg
approved these changes
Jun 11, 2025
zirain
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Makes it possible to configure the previous priorities retry for Route.
Which issue(s) this PR fixes:
Fixes #6181
Release Notes: Yes/No